Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try: PHP compat test with phpcompatibility-dev #331

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

Sidsector9
Copy link
Contributor

@Sidsector9 Sidsector9 commented Sep 27, 2022

Description of the Change

So we already have a PHP Compatibility action in place that tests for violations on PHP 8.0.

What this PR does is does the same but uses PHPCompatibility's dev branch . This is to ensure we are testing for violations with the latest changes. This is temporary until version 10.0.0 is released. Once released we can delete this and move these to the already existing PHP Compatibility action.

This action specifically runs on PHP 7.4 as recommended here.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Security - Added latest PHPCompatibility checks for PHP 8.0

Credits

Props @Sidsector9

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sidsector9 Sidsector9 requested a review from jeffpaul September 27, 2022 12:29
@Sidsector9 Sidsector9 self-assigned this Sep 27, 2022
@jeffpaul jeffpaul added this to the 1.3.0 milestone Sep 27, 2022
@jeffpaul
Copy link
Contributor

@Sidsector9 looks like the additional tests in develop for PHPCompat pass without any changes needed here, correct?

@Sidsector9
Copy link
Contributor Author

@jeffpaul they do, but in case the plugin has more code changes which can violate the latest rules in PHP Compat-dev, then this action will flag them, but the already existing ones won't.

@jeffpaul jeffpaul merged commit 510e135 into develop Sep 27, 2022
@jeffpaul jeffpaul deleted the php-compat-8-dev branch September 27, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants