Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/281: transient key name #282

Merged
merged 1 commit into from
May 18, 2022
Merged

fix/281: transient key name #282

merged 1 commit into from
May 18, 2022

Conversation

Sidsector9
Copy link
Contributor

@Sidsector9 Sidsector9 commented May 18, 2022 •
edited
Loading

Closes #281

Description of the Change

Corrects the transient name.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fix: incorrect posts due to wrong transient name

Credits

Props @Sidsector9

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Sidsector9 Sidsector9 self-assigned this May 18, 2022
@Sidsector9 Sidsector9 linked an issue May 18, 2022 that may be closed by this pull request
request status transient name mismatch #281
Closed
1 task
@Sidsector9 Sidsector9 requested a review from cadic May 18, 2022 12:49
cadic
cadic approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sidsector9, the root cause!

@jeffpaul jeffpaul added this to the 1.1.2 milestone May 18, 2022
@jeffpaul jeffpaul merged commit a5a59fc into develop May 18, 2022
@jeffpaul jeffpaul deleted the fix/281 branch May 18, 2022 13:02
@Sidsector9 Sidsector9 mentioned this pull request May 18, 2022
Merged
@jeffpaul jeffpaul linked an issue May 18, 2022 that may be closed by this pull request
Same content for blocks with different settings #278
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadic cadic cadic approved these changes

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

request status transient name mismatch Same content for blocks with different settings
3 participants
@Sidsector9 @cadic @jeffpaul