Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "SIT-2708:Update to save the response as a post meta field" #280

Merged
merged 3 commits into from
May 18, 2022
Merged

Revert "SIT-2708:Update to save the response as a post meta field" #280

merged 3 commits into from
May 18, 2022

Conversation

oscarssanchez
Copy link
Contributor

Reverts #253

@jeffpaul jeffpaul modified the milestones: 1.1.2, 1.1.3 May 17, 2022
@Sidsector9
Copy link
Contributor

Note: If this is reverted, we might want to revert PR #282 as well.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oscarssanchez
Copy link
Contributor Author

Hi @Sidsector9 ,

I believe the revert back of #282 should not bring any issues, since we don't have a post_id property anymore, let me know if you think differently. Thanks!

@Sidsector9
Copy link
Contributor

@oscarssanchez I may have worded it poorly. I added post_id in the transient name as part of PR #282
If we revert PR #280 , it will remove the usage of post_id, so we might also have to revert PR #282 as well.

@Sidsector9
Copy link
Contributor

Okay I just saw you pushed a commit. Looks good, approving 👍

@jeffpaul jeffpaul merged commit 543df44 into develop May 18, 2022
@jeffpaul jeffpaul deleted the revert-253-feature/save-sophi-responses-as-meta-fields-sit-2708 branch May 18, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidsector9 Sidsector9 Sidsector9 approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@oscarssanchez @Sidsector9 @jeffpaul