New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake success instead of failure on file operations #274

Merged

jeffpaul merged 1 commit into develop from fix/271

May 12, 2022

Contributor

cadic commented May 12, 2022 •

edited

Loading

Description of the Change

Custom Emitter will fake success for all file operations. It will prevent SyncEmitter from doing any output with print_r during initialization and performing requests.

Closes #271

Verification Process

Install and activate Sophi for WordPress
Install and activate Debug Bar for Sophi
Make directory read-only at wp-content/plugins/sophi/vendor/snowplow/snowplow-tracker
Create new post/page with Sophi Block
Click "Update"
Expected to successfully save post

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests passed.

Changelog Entry

Credits

Props @


          Fake success instead of failure on file operations

7d5483f

cadic self-assigned this

sonarqubecloud bot commented May 12, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

cadic requested a review from jeffpaul

May 12, 2022 17:35

cadic marked this pull request as ready for review

May 12, 2022 17:35

jeffpaul added this to the 1.1.1 milestone

jeffpaul merged commit 434a183 into develop

jeffpaul deleted the fix/271 branch

May 12, 2022 17:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet