Update dependency 10up-toolkit to v4 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
@cadic curious if any of the changes here will cause problems with the debug bar integration or if we're good to merge this into the core plugin? |
cadic
suggested changes
May 6, 2022
There was a problem hiding this comment.
@jeffpaul thank you for this upgrade. I see no conflicts with Sophi Debug Bar extension.
Testing this locally I found that npm run build fails in Node 12.
We still locked with Node 12 in this workflow, worth upgrading too:
|
@cadic probably bump to "node-version: '16'" yeah? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@jeffpaul I've pushed a commit with Node 16 |
cadic
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.1.2->4.0.0Release Notes
10up/10up-toolkit
v4.0.0Compare Source
@10up/block-components. Make sure to use the latest version of@10up/block-componentsthat already ships transpiled code. #181wp-polyfillas dependecy of scripts built by 10up-toolkit. #193.Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.