Rename duplicate filter #263
Conversation
includes/functions/content-sync.php
Outdated
| @@ -144,7 +144,7 @@ function send_track_event( $tracker, $post, $action ) { | |||
| * | |||
| * @return {array} Tracking data to send. | |||
| */ | |||
| $data = apply_filters_ref_array( 'sophi_tracking_data', array( $data, &$tracker, $post, $action ) ); | |||
| $data = apply_filters_ref_array( 'sophi_tracking_request_data', array( $data, &$tracker, $post, $action ) ); | |||
There was a problem hiding this comment.
Could similarly go with sophi_cms_tracking_request_data since this is the portion of the plugin where we send post publishing/update events, correct? Would be separate from the javascript tracking that happens on the site frontend, yeah?
There was a problem hiding this comment.
in which case maybe the other one gets updated to sophi_js_tracking_request_data?
There was a problem hiding this comment.
@jeffpaul great idea. I also updated the second filter sophi_cms_tracking_result for consistency
|
Kudos, SonarCloud Quality Gate passed!
|
|
@cadic looks like maybe we missed updating the docblock name of the hooks here? |
Description of the Change
Closes #262
Checklist:
Changelog Entry
Credits
Props @