SIT-2708:Update to save the response as a post meta field #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarssanchez
changed the title
felipeelia
previously approved these changes
May 3, 2022
…f github.com:globeandmail/sophi-for-wordpress into feature/save-sophi-responses-as-meta-fields-sit-2708
|
Kudos, SonarCloud Quality Gate passed!
|
felipeelia
approved these changes
May 3, 2022
oscarssanchez
deleted the
feature/save-sophi-responses-as-meta-fields-sit-2708
branch
jeffpaul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR will build from the work from Ramon. This changes the approach from saving the Sophi data into the options table to saving the data into post meta, adding a new "upgrader" function and hook to deal with previous installations of the plugin that update to the latest version.
We might also want to write in the documentation having object caching is encouraged, as we are saving the Sophi data as a transient. If a client does not have object cache the data will be saved as a transient in the options table, though these will eventually expire.
Closes #
Alternate Designs
Possible Drawbacks
Verification Process
Checklist:
Changelog Entry
Credits
Props @