Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track_event signature inside CLI command #250

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Apr 26, 2022

Description of the Change

This PR fixes track_event function call in CLI command, updating the arguments list to match the function declaration.

Closes #237

Possible Drawbacks

All posts being synced during wp sophi sync are considered as existing. Unknown behaviour on pushing update for posts which was not pushed before.

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jeffpaul jeffpaul added this to the 1.0.14 milestone Apr 26, 2022
@jeffpaul jeffpaul requested a review from Sidsector9 April 26, 2022 18:21
@jeffpaul jeffpaul merged commit 86ede8b into Mather-Sophi:develop Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function track_event called incorrectly
3 participants