Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache to the curated posts retrieved #157

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Dec 21, 2021

Description of the Change

This PR adds a transient to hold the curated posts retrieved. The key used in the transient relies on page and widget names. Other than that, it fixes the duplication content issue when two blocks are added to the same page.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Changed the way we cached the curated posts retrieved.

@Rahmon Rahmon added the bug Something isn't working label Dec 21, 2021
@Rahmon Rahmon added this to the 1.0.8 milestone Dec 21, 2021
@Rahmon Rahmon self-assigned this Dec 21, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu December 21, 2021 19:54
@jeffpaul
Copy link
Contributor

Also curious if @dinhtungdu has feedback here as well coming from the original Sophi build.

Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is LGTM as well 👏🏽

@jeffpaul
Copy link
Contributor

@Rahmon I'd say go ahead and merge this to continue your testing/triage... thanks!

@Rahmon Rahmon merged commit 70014db into develop Dec 22, 2021
@Rahmon Rahmon deleted the fix/cache-issue-sit-2704 branch December 22, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants