Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update auth_url in Auth.php #148

Merged
merged 1 commit into from
Oct 28, 2021
Merged

update auth_url in Auth.php #148

merged 1 commit into from
Oct 28, 2021

Conversation

jeffpaul
Copy link
Contributor

Description of the Change

This PR updates the hardcoded value for auth_url to the expected format from the Sophi team. See more in Teamwork: https://tenup.teamwork.com/#/tasks/18978984

Alternate Designs

n/a

Benefits

Ensures that the auth process works as Sophi is expecting.

Possible Drawbacks

Verification Process

Apply plugin settings, should no longer see Forbidden error message.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

@jeffpaul jeffpaul self-assigned this Oct 28, 2021
@jeffpaul jeffpaul requested a review from Rahmon October 28, 2021 15:47
@jeffpaul jeffpaul added this to the 1.0.7 milestone Oct 28, 2021
Rahmon
Rahmon approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@Rahmon Rahmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffpaul jeffpaul merged commit 36ef0be into develop Oct 28, 2021
@jeffpaul jeffpaul deleted the fix/auth_url branch October 28, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahmon Rahmon Rahmon approved these changes

Assignees

@jeffpaul jeffpaul

Labels
None yet
Projects
None yet
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffpaul @Rahmon