Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update categories in sectionNames field #144

Merged
merged 5 commits into from
Oct 25, 2021
Merged

Update categories in sectionNames field #144

merged 5 commits into from
Oct 25, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Oct 25, 2021

Description of the Change

This PR updates the sectionNames field to hold the categories preserving the hierarchy.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #141

Changelog Entry

Updated for handling of more than one set of hierarchical Categories on posts

@Rahmon Rahmon added the enhancement New feature or request label Oct 25, 2021
@Rahmon Rahmon requested review from felipeelia and jeffpaul October 25, 2021 13:47
@Rahmon Rahmon self-assigned this Oct 25, 2021
@jeffpaul jeffpaul added this to the 1.0.5 milestone Oct 25, 2021
jeffpaul
jeffpaul reviewed Oct 25, 2021
View reviewed changes
Copy link
Contributor

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will defer to @felipeelia's review on this one

@Rahmon Rahmon requested a review from jeffpaul October 25, 2021 20:44
jeffpaul
jeffpaul approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving via signoff from @tott

@Rahmon Rahmon merged commit 19b3418 into develop Oct 25, 2021
@Rahmon Rahmon deleted the chore/update-categories-in-sectionNames-field-sit-2503 branch October 25, 2021 21:09
@jeffpaul jeffpaul mentioned this pull request Oct 25, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

@felipeelia felipeelia Awaiting requested review from felipeelia

Assignees

@Rahmon Rahmon

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

SIT-3060: Allow for handling of more than one set of hierarchical Categories on posts
2 participants
@Rahmon @jeffpaul