Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change audience URL on request access token #143

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Oct 21, 2021

Description of the Change

This PR changes the audience URL on request access token from https://curator-api.sophi.io to https://site-automation-api.ml.sophi.io.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@Rahmon Rahmon requested review from felipeelia and jeffpaul October 21, 2021 18:54
@jeffpaul
Copy link
Contributor

This PR changes the audience URL on request access token from https://site-automation-api.ml.sophi.io to https://curator-api.sophi.io

Looks like the PR does the opposite... correct @Rahmon?

@jeffpaul jeffpaul added this to the 1.0.5 milestone Oct 21, 2021
@Rahmon
Copy link
Contributor Author

Rahmon commented Oct 21, 2021

This PR changes the audience URL on request access token from https://site-automation-api.ml.sophi.io to https://curator-api.sophi.io

Looks like the PR does the opposite... correct @Rahmon?

Yes. I've fixed. Thanks

Copy link
Contributor

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@Rahmon Rahmon merged commit 4c4f1ff into develop Oct 21, 2021
@Rahmon Rahmon deleted the chore/change-automation-URL-sit-2560 branch October 21, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants