Fix/homepage tracking sit 2447

[Rahmon]

Description of the Change

This change tries to:

• Prevent the plugin to track the homepage when it’s a CMS update
• Fix the tracking via JS when a user accesses the homepage.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Closes #123

Changelog Entry

Changed the tracking of the homepage on the Dashboard
Fixed the tracking of the homepage on the frontend

[jeffpaul]

This looks generally correct to me, but will defer to @felipeelia for a more official code review.

[felipeelia]

@Rahmon @jeffpaul not sure if I have the full context for this one but here are my 2 cents:

For track_event(): I wonder if this will behave as we'd expect if the WP admin user has set both Homepage (accessible by www.domain.com/, for example) and Posts page (www.domain.com/blog)? If we don't want to track any of those, then the code looks good. Otherwise, we'll need to adjust it a little bit.

For get_tracking_data(): With the same scenario in mind, isn't it a problem if we have two "homepages"?

[Rahmon]

@Rahmon @jeffpaul not sure if I have the full context for this one but here are my 2 cents:

For track_event(): I wonder if this will behave as we'd expect if the WP admin user has set both Homepage (accessible by www.domain.com/, for example) and Posts page (www.domain.com/blog)? If we don't want to track any of those, then the code looks good. Otherwise, we'll need to adjust it a little bit.

For get_tracking_data(): With the same scenario in mind, isn't it a problem if we have two "homepages"?

@felipeelia

For track_event(), we don't want to track any of those scenarios.

For get_tracking_data(), when you're accessing the homepage even if we have two homepages, we need to send the type as section.