Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: only use public hierarchial taxonomy for breadcrumb #109

Merged
merged 3 commits into from
Jul 23, 2021

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Jul 23, 2021

Description of the Change

This PR fixes the compatibility issue for sites using Co-Authors Plus and prevents similar issues for other plugins. With this PR, only public taxonomy is used to build the breadcrumb.

For special needs, the final taxonomy is now filterable so developers can control which taxonomy to use.

Thank @barryceelen for the suggestion!

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed: only use public taxonomies to build post breadcrumb.

@jeffpaul jeffpaul added this to the 1.0.4 milestone Jul 23, 2021
@jeffpaul jeffpaul requested a review from dkotter July 23, 2021 13:22
@jeffpaul jeffpaul added the bug Something isn't working label Jul 23, 2021
@jeffpaul jeffpaul merged commit 3d0d044 into develop Jul 23, 2021
@jeffpaul jeffpaul deleted the fix/hierarchy-taxonomy-data branch July 23, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants