Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency 10up-toolkit to v4.1.2 #46

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 22, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
10up-toolkit 4.0.0 -> 4.1.2 age adoption passing confidence

Release Notes

10up/10up-toolkit

v4.1.2

Compare Source

Patch Changes
  • 64134a9: Adding unmissable notice (error) when using HMR and SCRIPT_DEBUG is not set to true

    The recommended way of including the fast-refresh.php file is now the following:

    $is_local_env = in_array( wp_get_environment_type(), [ 'local', 'development' ], true );
    $is_local_url = strpos( home_url(), '.test' ) || strpos( home_url(), '.local' );
    $is_local     = $is_local_env || $is_local_url;
    
    if ( $is_local && file_exists( __DIR__ . '/dist/fast-refresh.php' ) ) {
    	require_once __DIR__ . '/dist/fast-refresh.php';
    	TenUpToolkit\set_dist_url_path( basename( __DIR__ ), TENUP_THEME_DIST_URL, TENUP_THEME_DIST_PATH );
    }
  • 86d68ac: Update devServer so the overlay only shows up on errors.
    Update StyleLintPlugin so it sets failOnError to false, similarly to EslintPlugin.

v4.1.1

Compare Source

Patch Changes
  • da9c394: Treat js files inside block or blocks directories as blocks. #​204

v4.1.0

Compare Source

Minor Changes
Patch Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@jeffpaul jeffpaul requested a review from cadic June 22, 2022 20:04
@jeffpaul jeffpaul added this to the 0.3.0 milestone Jun 22, 2022
@renovate renovate bot force-pushed the renovate/10up-toolkit-4.x branch 3 times, most recently from 82ba709 to 4eac427 Compare June 23, 2022 02:09
@jeffpaul
Copy link
Contributor

@cadic also helpful to get your review here to ensure this bump won't break anything in the Debug Bar plugin

@renovate renovate bot force-pushed the renovate/10up-toolkit-4.x branch from 4eac427 to 685bafc Compare June 24, 2022 14:56
@jeffpaul jeffpaul modified the milestones: 0.3.0, 0.4.0 Jun 30, 2022
cadic
cadic previously approved these changes Jul 4, 2022
Copy link
Contributor

@cadic cadic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul tested npm run build and plugin's basic functions in manual e2e test — all works as expected.

We could add new GitHub workflows to perform the build and automated E2E testing.

@renovate renovate bot force-pushed the renovate/10up-toolkit-4.x branch from 685bafc to b73ac49 Compare July 5, 2022 16:07
@jeffpaul jeffpaul modified the milestones: 0.4.0, 0.3.0 Jul 5, 2022
@jeffpaul jeffpaul merged commit 9d1889c into develop Jul 5, 2022
@jeffpaul jeffpaul deleted the renovate/10up-toolkit-4.x branch July 5, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants