Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting workflow trigger list #34

Merged
merged 4 commits into from
May 19, 2022
Merged

Fix linting workflow trigger list #34

merged 4 commits into from
May 19, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 19, 2022

Description of the Change

After upgrading 10up-toolkit to 4.0.0 in #31 some new rules were applied to stylelint, which is now causing linting errors in new PRs (#27, #32, #33).

In #31 actions, the linting job was skipped because no source files were changed.

This PR adds more sensitive files to the trigger list:

  • package.json and lockfile
  • eslint config
  • phpcs config

It will force linting job to run when the config changes even if no source files were changed (like it happened in #31)

Verification Process

Related issues/PRs

After this is merged, perform merge develop into #27, #32 and #33 to resolve GitHub Actions failure.

@cadic cadic requested a review from jeffpaul May 19, 2022 13:44
@cadic cadic added this to the Future Release milestone May 19, 2022
@cadic cadic marked this pull request as ready for review May 19, 2022 13:46
@cadic cadic self-assigned this May 19, 2022
@jeffpaul jeffpaul modified the milestones: Future Release, 0.3.0 May 19, 2022
@jeffpaul jeffpaul merged commit 9344e2d into develop May 19, 2022
@jeffpaul jeffpaul deleted the fix/lint branch May 19, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants