Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to Settings in plugin actions #32

Merged
merged 4 commits into from
May 19, 2022
Merged

Link to Settings in plugin actions #32

merged 4 commits into from
May 19, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 19, 2022

Description of the Change

Adds link to Sophi Settings before "Deactivate" in plugin actions.

Closes #20

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Add - Link to Sophi.io Settings in plugin actions

Credits

Props @cadic

@cadic cadic added this to the Future Release milestone May 19, 2022
@cadic cadic requested a review from a team May 19, 2022 06:42
@cadic cadic self-assigned this May 19, 2022
@cadic cadic requested review from iamdharmesh and removed request for a team May 19, 2022 06:42
iamdharmesh
iamdharmesh approved these changes May 19, 2022
View reviewed changes
Copy link

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cadic cadic mentioned this pull request May 19, 2022
Merged
@jeffpaul jeffpaul modified the milestones: Future Release, 0.3.0 May 19, 2022
@jeffpaul jeffpaul merged commit 7f01dcc into develop May 19, 2022
@jeffpaul jeffpaul deleted the enhancement/settings-link branch May 19, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Add Plugins page Settings link
3 participants
@cadic @iamdharmesh @jeffpaul