Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node dependencies update #31

Merged
merged 3 commits into from
May 19, 2022
Merged

Node dependencies update #31

merged 3 commits into from
May 19, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 18, 2022

Description of the Change

  • Upgraded husky and 10up-toolkit to latest versions
  • Removed react-dom (a dependency of json-viewer, was added to match eslint warnings, not applicable anymore)
  • Removed prop-types (rudimentary from 10up-scaffold, not used)

Closes #24

Verification Process

Performed regular NPM tasks

npm install
npm run build
npm run watch
npm run archive
npm update

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@cadic cadic requested a review from a team May 18, 2022 16:14
@cadic cadic self-assigned this May 18, 2022
@cadic cadic requested review from dinhtungdu and removed request for a team May 18, 2022 16:14
@cadic cadic added this to the 0.3.0 milestone May 18, 2022
Copy link

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cadic cadic merged commit 849bc9b into develop May 19, 2022
@cadic cadic deleted the fix/24 branch May 19, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm update error
2 participants