Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined index notice #27

Merged
merged 3 commits into from
May 19, 2022
Merged

Fix undefined index notice #27

merged 3 commits into from
May 19, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 18, 2022

Description of the Change

Add isset check for array index before accessing it.

Closes #26

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fix - PHP Notice on empty request body

Credits

Props @cadic

@cadic cadic added this to the 0.3.0 milestone May 18, 2022
@cadic cadic self-assigned this May 18, 2022
@cadic cadic requested review from a team and iamdharmesh and removed request for a team May 18, 2022 13:11
@cadic cadic mentioned this pull request May 19, 2022
Merged
@jeffpaul jeffpaul merged commit e4d6b8a into develop May 19, 2022
@jeffpaul jeffpaul deleted the fix/26 branch May 19, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh Awaiting requested review from iamdharmesh iamdharmesh was automatically assigned from 10up/open-source-practice

Assignees

@cadic cadic

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Debug Bar Notice on includes/classes/Request.php:24
2 participants
@cadic @jeffpaul