-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/build deploy #10
Fix/build deploy #10
Conversation
.distignore
Outdated
/.editorconfig | ||
/.eslintignore | ||
/.eslintrc.json | ||
/.gitattributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably remove the gitattributes file
.distignore
Outdated
/package.json | ||
/phpcs.xml | ||
/README.md | ||
/*.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this here for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this in case plugin dirtro zip which was made by npm run archive
script is present. It will never appear within the current push-deploy workflow, should we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will delete it for now, we can add it later when it's really required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't think I've seen that creep in, so probably fine to remove but good idea to have ready in case that does end up happening here
@@ -13,6 +13,7 @@ jobs: | |||
run: | | |||
npm install | |||
npm run build | |||
composer install --no-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to add this same step to the readme/asset action as well?
https://github.com/10up/sophi-debug-bar/blob/5f13d331ff27a21802d62188d6561f93ad44b14c/.github/workflows/wordpress-plugin-asset-update.yml#L12-L15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, we also need vendor folder to exist (otherwise the deploy script might consider "Other files have been modified")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments/updates needed, thanks for getting this started so quickly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you!
Description of the Change
composer install —no-dev
command to the build stepCloses #6
Verification Process
The release process was verified by replicating commands which the action will perform:
The resulting
![Screenshot 2022-05-11 at 18 24 49](https://user-images.githubusercontent.com/288381/167887695-bc8cd400-82e7-460b-b1c8-000c13d25964.png)
trunk/
folder contains correct list of files:Checklist:
Changelog Entry
Credits
Props @cadic