Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/build deploy #10

Merged
merged 9 commits into from
May 12, 2022
Merged

Fix/build deploy #10

merged 9 commits into from
May 12, 2022

Conversation

cadic
Copy link
Contributor

@cadic cadic commented May 11, 2022

Description of the Change

  1. Added .distignore
  2. Added composer install —no-dev command to the build step
  3. Updated textdomain

Closes #6

Verification Process

The release process was verified by replicating commands which the action will perform:

  1. npm install
  2. npm run build
  3. composer install --no-dev
  4. rsync -rc --exclude-from=".distignore" . trunk/ --delete --delete-excluded

The resulting trunk/ folder contains correct list of files:
Screenshot 2022-05-11 at 18 24 49

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fix - Deploy to WordPress.org action

Credits

Props @cadic

@cadic cadic added this to the 0.2.0 milestone May 11, 2022
@cadic cadic requested a review from jeffpaul May 11, 2022 15:26
@cadic cadic self-assigned this May 11, 2022
.distignore Outdated
/.editorconfig
/.eslintignore
/.eslintrc.json
/.gitattributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably remove the gitattributes file

.distignore Outdated
/package.json
/phpcs.xml
/README.md
/*.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this here for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this in case plugin dirtro zip which was made by npm run archive script is present. It will never appear within the current push-deploy workflow, should we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete it for now, we can add it later when it's really required

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't think I've seen that creep in, so probably fine to remove but good idea to have ready in case that does end up happening here

@@ -13,6 +13,7 @@ jobs:
run: |
npm install
npm run build
composer install --no-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we also need vendor folder to exist (otherwise the deploy script might consider "Other files have been modified")

Copy link
Contributor

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/updates needed, thanks for getting this started so quickly!

@cadic cadic requested a review from jeffpaul May 12, 2022 05:36
Copy link
Contributor

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@jeffpaul jeffpaul merged commit ae3abe7 into develop May 12, 2022
@jeffpaul jeffpaul deleted the fix/build-deploy branch May 12, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix build process
2 participants