-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoundTripEnvelope should use a more compact data format #5
Comments
Honestly, I have always imagined that the interceptor would look something like this: With layers being added / removed as necessary. |
We added compression in this PR, compression, I should have mentioned that @stravid87. |
Let me interest you in one such implementation we can plug and play: https://github.com/bincode-org/bincode |
Followup on this issue, we hit an improvement ratio of 0.9998 for a 5MB file asset sample when using bincode compared to JSON bytes. Leaving the issue open for later investigation. |
Problem
If you compare the encoded data for file assets that is sent encoded to JSON, we have a scenario where ~300kb file asset becomes a ~2MB json payload.
A good approach would be to create or use custom binary encoding formats to optimise for size. This would be perfectly backwards compatible with the current API we have in place.
More on this: https://stackoverflow.com/questions/49096721/json-transfer-vs-binary-transfer
The text was updated successfully, but these errors were encountered: