Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make process.exit hack tidier #41

Closed
graingert opened this issue Oct 5, 2017 · 3 comments
Closed

make process.exit hack tidier #41

graingert opened this issue Oct 5, 2017 · 3 comments

Comments

@graingert
Copy link
Contributor

Now that mochajs/mocha#1059 is released the process.exit hack could be tidier
@graingert
Copy link
Contributor Author

@glenjamin now that I look into this, I'm not actually sure how to do it.

@glenjamin
Copy link
Owner

I'm not really sure either anymore.

I think when I wrote that TODO it was before the code to wait for the streams to finish existed - now that this exists I'm not sure the monkeypatching can be removed

@graingert
Copy link
Contributor Author

@glenjamin probably ready for a release then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glenjamin @graingert