You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem is that uses a keyword argument after an optional argument. This leads to situations where backward compatibility is broken. For instance, this used to work fine:
I18n::Tasks::BaseTask.new(locales: some_locales)
Now it throws an ArgumentError because ruby tryies to allocate the passed arguments as part of the keywords hash.
So now you have to call the method like this, which seems illogical to me:
PR #394 introduced a new argument in
BaseTask
:i18n-tasks/lib/i18n/tasks/base_task.rb
Line 42 in 1b9e046
The problem is that uses a keyword argument after an optional argument. This leads to situations where backward compatibility is broken. For instance, this used to work fine:
Now it throws an
ArgumentError
because ruby tryies to allocate the passed arguments as part of the keywords hash.So now you have to call the method like this, which seems illogical to me:
This is going to broke some CI tests around. Maybe it would be better to use only one style for the method argument definition?
The text was updated successfully, but these errors were encountered: