setScene() ignores mesh.geometry reassignment

[ycw]

Describe the bug

setScene() ignores mesh.geometry reassignment in the following situation:

const mesh = new Mesh(new THREE.BoxGeometry(1,1,1), new THREE.MeshStandardMaterial())
pathTracer.setScene(scene, camera)

mesh.geometry = new THREE.BoxGeometry(2,1,1) // assigns new box geometry(2x1x1)
pathTracer.setScene(scene, camera) // old box geometry(1x1x1) gets rendered

Expected behavior

I expected that pathtracer honors mesh.geometry reassignment.

Workarounds

Renews mesh uuid right after assigning new geometry.

Screenshots and Demos

https://jsfiddle.net/0kyq5g7d/1

setScene.not.detect.geometry.changes.mp4

Packages

three@0.165.0
three-gpu-pathtracer@0.0.22

[gkjohnson]

cc @dongho-shin - do you want to take a look at this?

[dongho-shin]

StaticGeometryGenerator compare mesh.uuid with cached so it(just change geometry inside of the mesh) may NO_CHANGE for now
StaticGeometryGenerator.js near line 238

I think cache comparison method of StaticGeometryGenerator needs to be cleaned up or refactored once.

[gkjohnson]

I took a look at the cache a bit more and found a few issues. It should be fixed in #647. It would be great if you guys could try it to make sure it fixes the issue.

Hopefully in the future we won't have to rely on a full scene static geometry generator - which is a fairly complex to run quickly - but that might be a bit further out.

[gkjohnson]

@ycw I've just published v0.0.23 if you'd like to update the three.js editor. Thanks again for the report and repro.

[ycw]

Good.

mrdoob/three.js#28587