Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bitbucket Server] Open in Gitpod uses incorrect URLs for BBS repos previously opened on non-scm contexts #9128

Closed
jldec opened this issue Apr 5, 2022 · 2 comments
Labels
meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@jldec
Copy link
Contributor

jldec commented Apr 5, 2022

To reproduce (with Bitbucket Server)

  • Open a workspace on a prefixed repo url like https://at-bbs.staging.gitpod-dev.com/#https://bitbucket.gitpod-self-hosted.com/users/alextugarev/repos/yolo/browse - this should open a Gitpod workspace IDE
  • Go to dashboard and use Cmd-O to open another workspace
  • Choose the first entry e.g. https://bitbucket.gitpod-self-hosted.com/alextugarev/YOLO
  • Observe error
    Screenshot 2022-04-05 at 13 02 32
    Screenshot 2022-04-05 at 13 02 46
@jldec jldec added the team: webapp Issue belongs to the WebApp team label Apr 5, 2022
@AlexTugarev
Copy link
Member

found this in protocol.ts

export function getFullRepositoryName(ws: Workspace): string | undefined {
if (CommitContext.is(ws.context)) {
return ws.context.repository.owner + '/' + ws.context.repository.name
}
return undefined;
}
export function getFullRepositoryUrl(ws: Workspace): string | undefined {
if (CommitContext.is(ws.context)) {
return `https://${ws.context.repository.host}/${getFullRepositoryName(ws)}`
}
return undefined;
}

we need to revise these kind of assumptions.

@jldec jldec added the type: bug Something isn't working label Apr 6, 2022
@stale
Copy link

stale bot commented Jul 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 7, 2022
@stale stale bot closed this as completed Aug 16, 2022
@geropl geropl added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants