Preferences are not considered at startup on already opened files

[mrussmann]

Describe the bug
Preferences are not considered at startup on already opened files.

To Reproduce
Switch eg. codelense in your preferences off, adjust fontsize in your preference file.
Open some files, restart workspace, on already opened files codelense is switched on again and the fontsize is set to default.
Close the files and reopen everything is ok.

Expected behavior
Preferences are also considered on already opened files.

[JesterOrNot]

What's the link to the repo that might help

[mrussmann]

on all my workspaces! I am currently writing java code. Just switched codelense off and did a simple reload of the workspace in the browser -> after the reload codelense is on and the font size is extremly small.

[JesterOrNot]

So what is the issue? could you explain it in more detail?

[mrussmann]

switch code lense off - can you do that?

[mrussmann]

easier example: put this in your pref file:
"editor.fontSize": 22, <- which is big
then open a code file, size should be set to 22,
then do a browser reload,
the font size is the default font size, not 22

[JesterOrNot]

in your user preferences is autosave on? it's possible that you didn't save the settings so when you refreshed the changes did not persist

[mrussmann]

the pref is saved, it is persistent, it only happens on a browser reload and on workspace startup when the files are already opened. it worked before the update last week. have you tried it?

[JesterOrNot]

I see

[jankeromnes]

@mrussmann sorry about that problem, and thank you for reporting it. Also, thank you @JesterOrNot for helping reproduce the bug.

@AlexTugarev could you please look into this if you have some time? 🙂

[AlexTugarev]

Sounds like a bug in Theia. Thanks for reporting!

[mrussmann]

any news on this? after a reload or a restart the font size of the opened files is nearly unreadable.

[JesterOrNot]

Should this issue be refiled against theia and if so can we close this issue

[svenefftinge]

There seems to be a race where the editors are not updated once the preferences are initialized.

[svenefftinge]

I have fixed it in Theia. eclipse-theia/theia#6450
Will land in Gitpod in a couple of days.

[svenefftinge]

In production now