Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte Language Tools broken #4034

Closed
jacob-8 opened this issue Apr 22, 2021 · 2 comments
Closed

Svelte Language Tools broken #4034

jacob-8 opened this issue Apr 22, 2021 · 2 comments

Comments

@jacob-8
Copy link

jacob-8 commented Apr 22, 2021

Bug description

When starting an example workspace using the SvelteKit example from https://www.gitpod.io/#get-started, I receive two VSCode messages: Couldn't start client Svelte and vscode.languages.registerDocumentSemanticTokensProvider is not a function

image

The features of the Svelte for VS Code language tools extension don't work as a result.

Steps to reproduce

Create a new SvelteKit example workspace and watch for the messages in the lower right corner.

Expected behavior

Svelte for VS Code language tools should work (commands like Format Document inside of a .svelte file)

Example repository

No response

Anything else?

If I uninstall Svelte for VS Code (listed currently as v104.9.1) for the project, close the tab (but not the workspace) then re-open the workspace from the dashboard, I notice that Svelte for VS Code is no longer in the "Installed for this project" but is now listed in "Installed for " in the Extensions pane and it works fine. Note that it says v.101.1.1 when going this route.

Not sure if the changes to the extension to support ESM described in sveltejs/language-tools#930 are relevant.

@mikenikles
Copy link
Contributor

Hi, thanks for reporting that 🙏 ! I can't reproduce that unfortunately, I'm surprised v.101.1.1 works as it was released on Jul 8, 2020. Looking at the changelog, I see v.104.9.0 added support for ESM configs so that should be ok.

I wonder if there may have been a temporary issue, although I see you reported that a few minutes ago and I tested not long after you opened the issue. Please let me know if you continue to see this issue, I will be back in the morning and re-test again with a few new workspaces on my end to see if I can reproduce it.

@jacob-8
Copy link
Author

jacob-8 commented Apr 22, 2021

Sorry, I logged in to Gitpod a year ago and so my settings defaulted to Theia and evidently I also had an old version of that extension installed. Consider giving users who haven't logged in recently a notice that they can switch to VS Code if they are defaulted to Theia??

@jacob-8 jacob-8 closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants