Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for raw git URLs #167

Open
meysholdt opened this issue Dec 4, 2018 · 6 comments
Open

Support for raw git URLs #167

meysholdt opened this issue Dec 4, 2018 · 6 comments
Labels
meta: never-stale This issue can never become stale priority: 💪 stretch goal This issue is a stretch goal within an iteration. type: feature request New feature or request

Comments

@meysholdt
Copy link
Member

it would be great if Gitpod could handle URLs for schemes http:// and https:// in exactly the same format as it is understood by git clone <git-url>.

We should evaluate if we can make https://gitpod.io/#<git-url> work or if this causes ambiguities with GitHub-URLs.

URLs that require password authentication or an installed SSH-key should be handled in separate issues.

@csweichel
Copy link
Contributor

We'd need a way to identify if that's a raw Git URL. Two ways come to mind:

  1. Introduce a special modifier, e.g. https://gitpod.io/#git/<git-url>
  2. Try all other context parser first and if they can't handle the URL fall back to the Git parser (which in turn can attempt some magic to check if the URL actually is a Git repo).

The first option is easier, probably more reliable and more performant (in option 2 all wrong contexts might need to undergo HTTP requests to some wrong URL).
Option two is way nicer for users and closer to what one might expect.

@svenefftinge
Copy link
Member

For github, gitlab and so on we can tell by the first segment what context parser to use. So we could possibly use the raw git for everything else.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 4, 2020
@jankeromnes jankeromnes added type: feature request New feature or request and removed meta: stale This issue/PR is stale and will be closed soon labels Mar 10, 2021
@jankeromnes jankeromnes added this to the [backlog] April 2021 milestone Mar 10, 2021
@lukechu10
Copy link

Wouldn't this effectively make it possible to use private GitHub repos in the free plan?

@nurkiewicz
Copy link

Hi there! Any news on this issue? I can contribute or help in any other way in the development or testing

@jankeromnes jankeromnes added the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Apr 13, 2021
@geropl geropl modified the milestones: April 2021, May 2021 (backlog) Apr 13, 2021
@csweichel csweichel removed this from the May 2021 (backlog) milestone May 6, 2021
@rfay
Copy link

rfay commented Jun 20, 2021

This seems like a great initiative. It would make some of the things we want to do with Drupal contribution so much easier.

AFAICT, the difference between a raw git URL and an explicit integration is that you can't do prebuild with a raw git URL and you have to either be expecting just to pull (which might be OK for many things) but if you wanted to push you'd have to have auth of one type or another.

@ghuntley ghuntley added the meta: never-stale This issue can never become stale label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: never-stale This issue can never become stale priority: 💪 stretch goal This issue is a stretch goal within an iteration. type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants