Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyside6 issues (Windows and Linux) #494

Closed
nmstoker opened this issue Mar 16, 2023 · 11 comments
Closed

Pyside6 issues (Windows and Linux) #494

nmstoker opened this issue Mar 16, 2023 · 11 comments

Comments

@nmstoker
Copy link

There appear to be problems with Pyside6 python bindings and I seem not to be the only one observing this.

I'm AFK right now, so I'll flesh this out with more details soon, but on Linux I saw the examples cause segfaults and on Windows I initially had the "simple" example work briefly, in so far as it draws a window, but then freezes on any action. I believe the error message was similar to those tagged onto the end of #298.

It felt best to put this into a district issue rather than follow those sticking this questions on the end of a closed issue.

There is the QT Designer message appearing too but my understanding from online research is that that isn't likely to be the cause of the crashes.

@wuyuanyi135
Copy link

I too observe the faulty behavior: the simple example will hang once dragging the tab or click any button on the tab; the other examples segfaults on start.

@nmstoker
Copy link
Author

I'm back at the Windows computer now. I commented out almost all the code in the simple example and then step-by-step added it back.

Until the self.dock_manager.addDockWidget line, it's fine, no crashes although nothing docking based actually shows up. Then when I am that line it hangs as soon as there's any interaction with the docking item (ie the label).

The hang doesn't actually trigger any error or other message in the terminal, but Windows does eventually realise the app isn't responding.

The code of the simple.py example is here: https://github.com/mborgerson/Qt-Advanced-Docking-System/blob/pyside6/examples/simple/main.py

I'll try testing qtpy just to rule out that I'm not having an issue with that part, but beyond that I'm not sure how best to proceed given the lack of obvious error messages etc.

@wuyuanyi135
Copy link

I have tested several combinations of PySide6 & ADS. I found the PySide6-QtAds <= 3.8.3.1 works without crash.

@nmstoker
Copy link
Author

Ah, I'll see if that helps here and report back. Thank you!

@mborgerson
Copy link

mborgerson commented Mar 30, 2023

I have tested several combinations of PySide6 & ADS. I found the PySide6-QtAds <= 3.8.3.1 works without crash.

@nmstoker @wuyuanyi135 Do you have the required version of PySide6 installed when you observed the crash with the latest version of PySide6-QtAds 4.0.1.1 wheels? The current release of PySide6-QtAds wheels require specifically PySide6-Essentials==6.4.2, and soon will be updated and will require 6.4.3. The app I put these bindings together for (https://github.com/angr/angr-management) is tested to run on all platforms, so I suspect this is the root cause of your issues.

Apparently there was an ADS API update to addDockWidget that I failed to mirror in the bindings, and unfortunately went unnoticed when the build process did not fail. Oops! This should be fixed soon.

Thanks for reporting!

@mborgerson
Copy link

I think this should be resolved now with PySide6-QtAds 4.0.1.2 release, now on PyPI. Please try it out and let me know

@nmstoker
Copy link
Author

@mborgerson - I'd successfully moved to using PySide6-QtAds == 3.8.3.1 based on what @wuyuanyi135 has found.

Let me try to reproduce the steps I'd done with the segfaults to confirm exactly what versions I had of everything. That'll need to be tomorrow as am travelling today.

Thanks for looking into this and thanks too for the great examples (a big help in understanding the various features!)

@nmstoker
Copy link
Author

nmstoker commented Mar 30, 2023

Ah, our messages must've passed in the ether. I'll try out PySide6-QtAds 4.0.1.2 as well and report back on that tomorrow (Friday)
Thanks!

@wuyuanyi135
Copy link

I could confirm after the binding fix it no longer crashes! Thanks for fixing the issue

@nmstoker
Copy link
Author

nmstoker commented Apr 2, 2023

I confirmed that PySide6-QtAds 4.0.1.2 with PySide6 (6.4.3) works well now, no crashes. Thanks again @mborgerson

@mborgerson
Copy link

@nmstoker @wuyuanyi135 Glad to hear it, and thanks to @n-elie for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants