Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a dock with CDockWidget::DockWidgetDeleteOnClose set does not emit closed() signal #134

Closed
nickdademo opened this issue Mar 24, 2020 · 6 comments
Assignees

Comments

@nickdademo
Copy link

As the title says:

Closing a dock with CDockWidget::DockWidgetDeleteOnClose set does not emit closed() signal.

Is this by design?

The only way to detect a dock close in this case is via:
CDockManager::dockWidgetRemoved

@nickdademo
Copy link
Author

I also assume this commented-out line can be removed: https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System/blob/master/src/DockAreaWidget.cpp#L500

@githubuser0xFFFF githubuser0xFFFF self-assigned this Mar 25, 2020
@githubuser0xFFFF
Copy link
Owner

I just fixed this with commit c541f2c

Please test, if it works now.

@nickdademo
Copy link
Author

Fixed, thanks!

@githubuser0xFFFF
Copy link
Owner

I fixed your issues quickly, so it woul be fair, if you could support this project with a 10 Euro donation via the PayPal button on the front page. Thank you.

@githubuser0xFFFF
Copy link
Owner

Thank you very much for your donation 😃. If you have an application that I can show on the frontpage in the showcase section or that you would like to show, then it would be great, if you have a screenshot, where the ADS is visible and a text about your application.

Thank you again and kind regards, Uwe

@nickdademo
Copy link
Author

Thank you very much for your donation 😃. If you have an application that I can show on the frontpage in the showcase section or that you would like to show, then it would be great, if you have a screenshot, where the ADS is visible and a text about your application.

Thank you again and kind regards, Uwe

Definitely! Will be in touch soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants