Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Maximum call stack size exceeded error" with 3.0.9 #130

Closed
dmarcey opened this issue Nov 19, 2019 · 0 comments · Fixed by #131
Closed

"Maximum call stack size exceeded error" with 3.0.9 #130

dmarcey opened this issue Nov 19, 2019 · 0 comments · Fixed by #131

Comments

@dmarcey
Copy link
Contributor

dmarcey commented Nov 19, 2019

It looks like the update to 3.0.9 introduced an infinite loop in the <relative-time /> element.

Repro Link:
https://codesandbox.io/s/thirsty-joliot-44k9p
Repro Steps:

  • Open link
  • Open browser console
  • Refresh
Uncaught RangeError: Maximum call stack size exceeded.
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
    at evaluate (index.js? [sm]:6)
    at Jn (eval.js:61)
    at e.value (transpiled-module.ts:980)
    at e.value (manager.ts:361)
    at t (transpiled-module.ts:958)
    at loadResources (index.html:3)

Compare to https://codesandbox.io/s/wizardly-dew-7pih0 which is using 3.0.8 and does not have the issue.

Here is the relevant code:

if (title && (!currentTitle || currentTitle === oldTitle)) {
        this.setAttribute('title', title);
      }

which I think was modified in this PR:
#129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant