Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .coffee.md to Literate Coffeescript #4957

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Aug 25, 2020

Description

Checklist:

  • I am associating a language with a new file extension.
    • The new extension is used in hundreds of repositories on GitHub.com
      • Search results for each extension:

It seems github search is broken for multiple-part extensions like .coffee.md as it doesn't return any results (even the provided sample): https://github.com/search?q=extension%3Acoffee.md+require&type=Code

@lildude
Copy link
Member

lildude commented Aug 25, 2020

It seems github search is broken for multiple-part extensions like .coffee.md as it doesn't return any results (even the provided sample): https://github.com/search?q=extension%3Acoffee.md+require&type=Code

It's not perfect, but we can get closer with path:coffee extension:md require which in this case only brings up 28 results.

Switching out require for NOT nothack returns only 900-odd results, many of which are legit markdown files so I don't think we can include this just yet.

@sheerun
Copy link
Contributor Author

sheerun commented Aug 25, 2020

Google Bigquery for:

SELECT COUNT(*) FROM (
  SELECT repo_name FROM `bigquery-public-data.github_repos.files`
  WHERE ENDS_WITH(path, ".coffee.md")
  GROUP BY repo_name
)

returns 1250 repositories (not files), which have such extensions, for github in 2015. So I guess it qualifies?

@lildude
Copy link
Member

lildude commented Aug 25, 2020

Ah yes. Of course. I forgot BigQuery could search for cases like that. Yup. Looks like we've got the numbers.

@lildude lildude merged commit 28dcaa3 into github-linguist:master Aug 30, 2020
sambacha pushed a commit to freight-trust/linguist that referenced this pull request Sep 4, 2020
Alhadis added a commit to file-icons/atom that referenced this pull request Sep 17, 2020
Added:
* CoffeeScript: `.coffee.md` (github-linguist/linguist#4957)
* Lex:          `lexer.x`    (github-linguist/linguist#4952)
* NGINX:        `.nginx`     (github-linguist/linguist#4965)
* Ruby:         `.simplecov` (github-linguist/linguist#4976)
exuanbo added a commit to exuanbo/file-icons-js that referenced this pull request Oct 15, 2020
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants