-
Notifications
You must be signed in to change notification settings - Fork 1.9k
META: Merge karma.coffee and plusplus.coffee #1192
Comments
If this is going to happen, it's also a good opportunity to move it out to an external package cc #1113 |
👍 |
👍 (or should I say, issue-1992++) I'll take a stab at this; I also have a much more advanced version that I need to upload anyway. |
gooooOOOOO TEAM! breaks out a dizzy drink 🍺 |
It does look pretty similar; hey @davereid, how attached are you to the word
Also, my newer version also includes |
For what it's worth, he was just mimicking behaviour of the bot in the drupal irc channels: Not sure his use-case though |
Nice! I'll close this and we can move to that issue queue :) |
Forked from #1180
https://github.com/github/hubot-scripts/blob/master/src/scripts/karma.coffee
https://github.com/github/hubot-scripts/blob/master/src/scripts/plusplus.coffee
Looks like everything is unifiable except the root namespace, but if it would help resolve things, we could use block regular expressions to allow interpolated pieces into the regex, which would allow us to provide overriddable defaults for the regex stuff:
http://coffeescript.org/#regexes
Thoughts?
cc: @ajacksified @davereid
The text was updated successfully, but these errors were encountered: