Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

META: Merge karma.coffee and plusplus.coffee #1192

Closed
patcon opened this issue Oct 16, 2013 · 8 comments
Closed

META: Merge karma.coffee and plusplus.coffee #1192

patcon opened this issue Oct 16, 2013 · 8 comments

Comments

@patcon
Copy link
Contributor

patcon commented Oct 16, 2013

Forked from #1180

https://github.com/github/hubot-scripts/blob/master/src/scripts/karma.coffee
https://github.com/github/hubot-scripts/blob/master/src/scripts/plusplus.coffee

Looks like everything is unifiable except the root namespace, but if it would help resolve things, we could use block regular expressions to allow interpolated pieces into the regex, which would allow us to provide overriddable defaults for the regex stuff:
http://coffeescript.org/#regexes

Thoughts?

cc: @ajacksified @davereid

@technicalpickles
Copy link
Contributor

If this is going to happen, it's also a good opportunity to move it out to an external package cc #1113

@patcon
Copy link
Contributor Author

patcon commented Oct 16, 2013

👍

@ajacksified
Copy link
Contributor

👍 (or should I say, issue-1992++)

I'll take a stab at this; I also have a much more advanced version that I need to upload anyway.

@patcon
Copy link
Contributor Author

patcon commented Oct 16, 2013

gooooOOOOO TEAM! breaks out a dizzy drink 🍺

@ajacksified
Copy link
Contributor

It does look pretty similar; hey @davereid, how attached are you to the word karma? My API looks like:

  • name++
  • name--
  • ++ (gives a point to the most recent thing)
  • -- (similarly, subtracts a point from the most recent)
  • hubot top 10 (also shows a histogram using clark)
  • hubot bottom 10
  • hubot score name

Also, my newer version also includes name++ for reason, which keeps track of reasons (hubot score will show the reasons.)

@patcon
Copy link
Contributor Author

patcon commented Oct 16, 2013

For what it's worth, he was just mimicking behaviour of the bot in the drupal irc channels:
http://drupalcode.org/project/bot.git/tree/refs/heads/7.x-1.x:/bot_karma

Not sure his use-case though

@ajacksified
Copy link
Contributor

@patcon
Copy link
Contributor Author

patcon commented Oct 25, 2013

Nice! I'll close this and we can move to that issue queue :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants