Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

jira-issues.coffee inconsistent data return #1174

Closed
darksheer opened this issue Oct 8, 2013 · 4 comments
Closed

jira-issues.coffee inconsistent data return #1174

darksheer opened this issue Oct 8, 2013 · 4 comments

Comments

@darksheer
Copy link

Configured jira-issues.coffee and everything works.

After hubot detects a JIRA issue hubot returns information on the ticket. Making the same call anytime for 3 seconds - 1-2 minutes for the same issue ID and hubot returns not data.

Investigated heroku logs, but nothing shows any problems.

Is this just the script being graceful with the API? I have configured the VARS for both username + password, so would assume API / web calls wouldn't be limited.

@technicalpickles
Copy link
Contributor

Including previous contributors to this script: /cc @ianmurrays @jbcpollak @benjamine @brettporter @stuartf

I really could use someone to take over maintaing this and the other jira scripts as external packages if anyone is interested /cc #1113

@stuartf
Copy link
Contributor

stuartf commented Oct 15, 2013

This is the script being "graceful with the API" as you say, but also because I found that once people start discussing an issue it would get mentioned numerous times and it was annoying to have the bot keep responding to all of them with the same info. If you want to change the time it waits before responding again it's the line that looks like:

cache.push({issue: issue, expires: now + 120000})

That 120000 could be pulled out to an environment variable so that individual installations can adjust it as they wish.

@technicalpickles
Copy link
Contributor

@stuartf thanks for chiming in! I think's the issue @darksheer is running into. An environment variable would be pretty useful here, perhaps defaulting to not caching.

@brettporter
Copy link
Contributor

So it seems that recently 39e8f55 was applied, which changes the behaviour to that originally described. I agree this would be better as a configuration option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants