From 71471015df6ed286e093ff3ec98d918f5b1d10ab Mon Sep 17 00:00:00 2001 From: CapitainFlam <31761317+CapitainFlam@users.noreply.github.com> Date: Fri, 23 Sep 2022 22:08:40 +0200 Subject: [PATCH 1/5] solving issues#20289 - part 1/2 - adding text about 'file is downloaded' solving https://github.com/github/docs/issues/20289 --- .../working-with-advanced-formatting/attaching-files.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md index 9e3f76ad768a..af27781bab2c 100644 --- a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md +++ b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md @@ -56,4 +56,6 @@ We support these files: {% endnote %}{% endif %} +Once you attached a file, it will be upload directly to GitHub (it will NOT wait for issue/PR/comment submission). Then, you can see the new URL attached to this file, with a URL like https://user-images.githubusercontent.com/[random folder name]/[random identifications].png. This means that, even if you do NOT submit your issue/PR/comment, the file has _already_ been uploaded in GitHub servers, and can be reached through the [anonymized URL](https://github.com/github/docs/blob/main/github/authenticating-to-github/about-anonymized-urls). + ![Attachments animated GIF](/assets/images/help/pull_requests/dragging_images.gif) From 9f76a54ea5eecad109dbefa5309bf1dd674ed469 Mon Sep 17 00:00:00 2001 From: CapitainFlam <31761317+CapitainFlam@users.noreply.github.com> Date: Fri, 23 Sep 2022 22:20:04 +0200 Subject: [PATCH 2/5] Update attaching-files.md --- .../working-with-advanced-formatting/attaching-files.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md index af27781bab2c..13a611e066e7 100644 --- a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md +++ b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md @@ -56,6 +56,6 @@ We support these files: {% endnote %}{% endif %} -Once you attached a file, it will be upload directly to GitHub (it will NOT wait for issue/PR/comment submission). Then, you can see the new URL attached to this file, with a URL like https://user-images.githubusercontent.com/[random folder name]/[random identifications].png. This means that, even if you do NOT submit your issue/PR/comment, the file has _already_ been uploaded in GitHub servers, and can be reached through the [anonymized URL](https://github.com/github/docs/blob/main/github/authenticating-to-github/about-anonymized-urls). +Once you attached a file, it will be upload directly to GitHub (it will NOT wait for issue/PR/comment submission). Then, you can see the new URL attached to this file, with a URL like `https://user-images.githubusercontent.com/[random folder name]/[random identifications].png`. This means that, even if you do NOT submit your issue/PR/comment, the file has _already_ been uploaded in GitHub servers, and can be reached through the [anonymized URL](https://github.com/github/docs/blob/main/github/authenticating-to-github/about-anonymized-urls). ![Attachments animated GIF](/assets/images/help/pull_requests/dragging_images.gif) From 7188dfdadaa68ea2e40a86b5d776ea0168bb55be Mon Sep 17 00:00:00 2001 From: CapitainFlam <31761317+CapitainFlam@users.noreply.github.com> Date: Fri, 23 Sep 2022 22:21:04 +0200 Subject: [PATCH 3/5] Update attaching-files.md --- .../working-with-advanced-formatting/attaching-files.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md index 13a611e066e7..4a3f286358c5 100644 --- a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md +++ b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md @@ -56,6 +56,6 @@ We support these files: {% endnote %}{% endif %} -Once you attached a file, it will be upload directly to GitHub (it will NOT wait for issue/PR/comment submission). Then, you can see the new URL attached to this file, with a URL like `https://user-images.githubusercontent.com/[random folder name]/[random identifications].png`. This means that, even if you do NOT submit your issue/PR/comment, the file has _already_ been uploaded in GitHub servers, and can be reached through the [anonymized URL](https://github.com/github/docs/blob/main/github/authenticating-to-github/about-anonymized-urls). +Once you attached a file, it will be upload directly to GitHub (it will NOT wait for issue/PR/comment submission). Then, you can see the new URL attached to this file, with a URL like `https://user-images.githubusercontent.com/*random folder name*/*random identifications*.png`. This means that, even if you do NOT submit your issue/PR/comment, the file has _already_ been uploaded in GitHub servers, and can be reached through the [anonymized URL](https://github.com/github/docs/blob/main/github/authenticating-to-github/about-anonymized-urls). ![Attachments animated GIF](/assets/images/help/pull_requests/dragging_images.gif) From 32d3765a03a8271ba5242af45d7e61d4c88c2552 Mon Sep 17 00:00:00 2001 From: Felicity Chapman Date: Mon, 26 Sep 2022 08:50:20 +0100 Subject: [PATCH 4/5] Update content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md --- .../working-with-advanced-formatting/attaching-files.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md index 4a3f286358c5..b5cfc57d53cc 100644 --- a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md +++ b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md @@ -56,6 +56,6 @@ We support these files: {% endnote %}{% endif %} -Once you attached a file, it will be upload directly to GitHub (it will NOT wait for issue/PR/comment submission). Then, you can see the new URL attached to this file, with a URL like `https://user-images.githubusercontent.com/*random folder name*/*random identifications*.png`. This means that, even if you do NOT submit your issue/PR/comment, the file has _already_ been uploaded in GitHub servers, and can be reached through the [anonymized URL](https://github.com/github/docs/blob/main/github/authenticating-to-github/about-anonymized-urls). +When you attach a file, it is uploaded immediately to {% data variables.product.product_name %} and the text field is updated to show the anonymized URL for the file. {% ifversion fpt or ghec %}For more information on anonymized URLs see "[About anonymized URLs](/github/authenticating-to-github/about-anonymized-urls)".{% endif %} ![Attachments animated GIF](/assets/images/help/pull_requests/dragging_images.gif) From bf9826290c2e230d8a50844d94ec3b2b892c0da4 Mon Sep 17 00:00:00 2001 From: Felicity Chapman Date: Mon, 26 Sep 2022 09:01:12 +0100 Subject: [PATCH 5/5] Move the new paragraph above the list of file sizes for visibility --- .../working-with-advanced-formatting/attaching-files.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md index b5cfc57d53cc..0d8309b7b858 100644 --- a/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md +++ b/content/get-started/writing-on-github/working-with-advanced-formatting/attaching-files.md @@ -22,6 +22,8 @@ To attach a file to an issue or pull request conversation, drag and drop it into ![Select attachments from computer](/assets/images/help/pull_requests/select-bar.png) +When you attach a file, it is uploaded immediately to {% data variables.product.product_name %} and the text field is updated to show the anonymized URL for the file. {% ifversion fpt or ghec %}For more information on anonymized URLs see "[About anonymized URLs](/github/authenticating-to-github/about-anonymized-urls)".{% endif %} + {% tip %} **Tip:** In many browsers, you can copy-and-paste images directly into the box. @@ -56,6 +58,4 @@ We support these files: {% endnote %}{% endif %} -When you attach a file, it is uploaded immediately to {% data variables.product.product_name %} and the text field is updated to show the anonymized URL for the file. {% ifversion fpt or ghec %}For more information on anonymized URLs see "[About anonymized URLs](/github/authenticating-to-github/about-anonymized-urls)".{% endif %} - ![Attachments animated GIF](/assets/images/help/pull_requests/dragging_images.gif)