Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs seem to include old information on how to delete docker images from package registry. #982

Closed
simonholzapfel opened this issue Nov 2, 2020 · 19 comments
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team

Comments

@simonholzapfel
Copy link

regarding https://docs.github.com/en/free-pro-team@latest/packages/managing-container-images-with-github-container-registry/deleting-a-container-image

What is the current behavior?

how the actual manage versions page looks like:
image

how the docs look like:
image

What changes are you suggesting?

I suggest either fixing the docs, or fixing the manage versions page.

Additional information

I am on the GitHub Education plan.

@simonholzapfel simonholzapfel added the engineering Will involve Docs Engineering label Nov 2, 2020
@welcome
Copy link

welcome bot commented Nov 2, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 2, 2020
@Botfacke
Copy link

Botfacke commented Nov 3, 2020

Cool

@janiceilene janiceilene added ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team and removed engineering Will involve Docs Engineering labels Nov 3, 2020
@janiceilene
Copy link
Contributor

Thanks for opening an issue @simonholzapfel! I'll triage this for someone on the team to take a look at. Do you have admin privileges for the package you're trying to delete?

@simonholzapfel
Copy link
Author

Yes, since I am the owner of the repository and the publisher of the container image.

@lucascosti lucascosti removed the triage Do not begin working on this issue until triaged by the team label Nov 16, 2020
@lucascosti
Copy link
Contributor

lucascosti commented Nov 16, 2020

🤔 I'm seeing the same thing for my docker images...

@jmarlena Do you know who to ping about this procedure? Maybe @jcansdale knows?

@jmarlena
Copy link
Contributor

I'd ping @github/support-package-registry-ombuds, which includes @jcansdale.

@jmarlena
Copy link
Contributor

👋🏽 @simonholzapfel

Looking closer at this issue and not just the last immediate question, here's two thoughts on this:

  1. Is your package public or private? Because public packages will not show the delete button option.

  2. Also, just for your information, I think the UI here could be a bit different if you have container registry enabled but I suspect the main issue here is that your package is public.

@lucascosti
Copy link
Contributor

Is your package public or private? Because public packages will not show the delete button option.

🤔 I don't see this mentioned in the article. The article says:

When deleting public packages, be aware that you may break projects that depend on your package.

If public packages can't be deleted, we should probably update this and mention it. 🙂

@jcansdale
Copy link
Contributor

jcansdale commented Nov 18, 2020

regarding https://docs.github.com/en/free-pro-team@latest/packages/managing-container-images-with-github-container-registry/deleting-a-container-image

They're referencing docs for the GitHub Container Registry, where deleting public container images is possible,

I notice one of the screenshots is for the npm registry:
image

You can delete a version of a private container image using GraphQL or on GitHub.

We don't have a GraphQL API for deleting container images from the GitHub Container Registry. I think there are plans for a REST API, but not a GraphQL API like GitHub Packages has.

@simonholzapfel
Copy link
Author

@jmarlena Thanks for the info, my package is indeed public!
But how can container images be deleted then?

@simonholzapfel
Copy link
Author

I solved the issue by making the repo private, deleting the container images and making the repo public again, but this can't be the official way of solving this problem, right?

@jmarlena
Copy link
Contributor

jmarlena commented Nov 20, 2020

@simonholzapfel

I checked some test container images and I also didn't see the delete UI button but I learned that if you only have one container image version, the deletion button will be found in the options under "Danger zone." I wonder if this applies to you?

Either way, I see the need to update the article for this new UI. I can see how confusing this all is.

image

image

@jmarlena
Copy link
Contributor

Heads up, I've opened a PR to address the UI mismatching and confusing intro. Also, checking in on any related UI updates coming up to see how we can keep this evergreen. I'll delete this issue once the PR ships.

Someone is welcome to create a PR from this issue to fix the confusing intro as that doesn't seem to need more dialogue to fix. 🚀

@janiceilene janiceilene added the content This issue or pull request belongs to the Docs Content team label Nov 20, 2020
@Marcono1234
Copy link
Contributor

Marcono1234 commented Dec 7, 2020

It appears the docs also don't match the current UI for packages: "Deleting a version of a private package on GitHub".
(And the "Package Settings" button on the top right seems to be broken; it just brings me back to the packages overview)

Do you want a separate issue for that?

Edit: Nevermind, the UI does now actually match the one shown in the docs, except that the buttons have a slightly different style (the corners are more rounded). Though I am not sure if that is worth an issue. Either I was imagining things yesterday, or I was part of some sort of A/B-test.

@janiceilene
Copy link
Contributor

@Marcono1234 If you could open a separate issue, that'd be super helpful, thank you!

@tsal
Copy link

tsal commented Jan 21, 2021

The updates to this did absolutely nothing to clear up this issue. The current UI is so COMPLETELY out of whack with the document, one might think it was made for a different application entirely.

I am an admin (owner) of the repo and org, and I have no UI elements that match (rounded corners or otherwise) for managing packages. In fact, the only thing I can do is edit the description for any package version.

I get this is managed by open source, but this UI update has caused far, far more headaches than it has simplified anything.

This isn't on the community to fix, this is on GitHub to fix.

@jmarlena
Copy link
Contributor

jmarlena commented Jan 21, 2021

Hey @tsal,

To help clear up all the confusion here, I'd like to better understand the UI you're seeing and what type of packages and Docker registry you're using.

The UI to delete versions of private GitHub packages published on GitHub using this URL https://docker.pkg.github.com/OWNER/REPO/IMAGE-NAME should match the UI in this article:
https://docs.github.com/en/free-pro-team@latest/packages/manage-packages/deleting-a-package#deleting-a-version-of-a-private-package-on-github

The UI to delete Docker container images published on GitHub using this URL ghcr.io/OWNER/IMAGE-NAME (This is part of the improved container support beta release, which you must enable) should match the UI in this article:
https://docs.github.com/en/free-pro-team@latest/packages/guides/deleting-a-container-image

Does this clarify which UI you're expected to see?

We're in the process of reorganizing these packages docs to better clarify which version of the Docker package docs users will need. I'm wondering if this will clear up the confusing UI expectations.

@tsal
Copy link

tsal commented Jan 21, 2021

Thank you. The first link cleared up everything. I was expecting the UI to still be with the github packages interface, and did not find this updated documentation, despite a lot of searching, only this issue by virtue of another closed issue on this repo.

@jmarlena
Copy link
Contributor

The changes to fix this issue were shipped months ago now but this public issue wasn't closed then. 😅

Feel free to open up a new issue if you something else that needs clarity or a fix. 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team
Projects
None yet
Development

No branches or pull requests

8 participants