Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB_SHA is incorrectly documented or not functioning properly #4422

Closed
actual-nh opened this issue Mar 9, 2021 · 6 comments
Closed

GITHUB_SHA is incorrectly documented or not functioning properly #4422

actual-nh opened this issue Mar 9, 2021 · 6 comments
Labels
triage Do not begin working on this issue until triaged by the team

Comments

@actual-nh
Copy link

actual-nh commented Mar 9, 2021

What article on docs.github.com is affected?

https://docs.github.com/en/actions/reference/environment-variables

And possibly: https://docs.github.com/en/actions (for a clearer issue link).

What part(s) of the article would you like to see updated?

Either:

  • It is incorrect about the GITHUB_SHA variable being (supposed to be) that of the commit, and fails to say what the proper environment variable is for the SHA hash of the commit; or
  • The GITHUB_SHA environment variable is not being set correctly (and where to put in an issue for this is inadequately documented).

Additional information

I am attempting to do a test seed that will be consistent across various CI tests, including different architectures at Github and between Github and Travis. The only variable identifiable to enable this is the SHA of the commit (treated as a hex number and modulo an appropriate number to keep it within the range of the seed variable). On Travis, this is working properly with the TRAVIS_COMMIT variable, as can be seen at https://travis-ci.org/github/CleverRaven/Cataclysm-DDA/jobs/762182900#L1246. However, using the GITHUB_SHA environment variable, it is not working for Github, as can be seen at https://github.com/CleverRaven/Cataclysm-DDA/pull/47791/checks?check_run_id=2069095563#step:10:585 - compare to both the commit ID at the top of the page and the identical one used by Travis.

(The build script in use can be seen at https://github.com/actual-nh/Cataclysm-DDA/blob/weariness_order/build-scripts/build.sh, BTW.)

@welcome
Copy link

welcome bot commented Mar 9, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 9, 2021
@janiceilene
Copy link
Contributor

Thanks so much for opening an issue @actual-nh! I think this would be best resolved by our wonderful support team ✨ After you chat with them, if there are any docs updates needed, feel free to comment in this issue and let us know!

@actual-nh
Copy link
Author

@janiceilene: None of the support team categories seem appropriate; which would you advise?

@janiceilene
Copy link
Contributor

Hm, I'd try https://github.community/search?q=actions

@actual-nh
Copy link
Author

@janiceilene: That's not the support team, sorry.

@janiceilene
Copy link
Contributor

I'm sorry @actual-nh, I don't think I understood your question then. Could you clarify or add a screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

2 participants