Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angle brackets to email address in on-behalf-of CLI instructions #34498

Closed
wants to merge 1 commit into from

Conversation

hacker1024
Copy link

Why:

Closes: #34497

What's being changed (if available, include any code snippets, screenshots, or gifs):

Angle brackets have been added around the email address in the on-behalf-of CLI instructions, and the capitalization has been made consistent with the rest of the page.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Sep 5, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 5, 2024
@Niangelina

This comment was marked as spam.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-on-behalf-of-an-organization.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review pull requests Content related to pull requests and removed triage Do not begin working on this issue until triaged by the team labels Sep 5, 2024
@nguyenalex836
Copy link
Contributor

@hacker1024 Thank you for raising a PR and flagging this! ✨ Our style guide states the following regarding placeholder text:

Style any placeholder text in all caps. If a placeholder is multiple words, connect the words with dashes (kebab-case). If you use a placeholder, explain what someone might replace it with. This helps people modify examples to fit their needs and helps identify placeholders for people who use assistive technology.

Use:

  • In the following example, replace YOUR-REPOSITORY with the name of your repository. git init YOUR-REPOSITORY
  • Click Add USERNAME. Where USERNAME is the username of the person you want to add.

Avoid:

  • git init your repository
  • git init <your-repository>
  • Click Add username.

Would you be willing to update your PR to align the doc with the style guide? 💛

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Sep 12, 2024
Copy link
Contributor

This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process.

@github-actions github-actions bot closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review pull requests Content related to pull requests stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angle brackets are missing in the on-behalf-of CLI instructions
3 participants