OIDC hardening and defining trust misses some values from subject claims #34016
Labels
actions
This issue or pull request should be reviewed by the docs actions team
content
This issue or pull request belongs to the Docs Content team
fix-internally
Triggers a workflow to copy the issue internally and close the current issue
waiting for review
Issue/PR is waiting for a writer's review
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#example-subject-claims
What part(s) of the article would you like to see updated?
And then the following chapter demonstrates filtering for branches, environments, tags, and pull_request events.
That would lead me to expecting the tags and events in the quoted paragraph as well.
Additional information
Adding the tags seems straightforward, including the pull request events will need a bit more verbosity or changing that sentence around a bit.
Or, the sentence can be reworded to be taken as an example only, not providing the complete list of options.
The text was updated successfully, but these errors were encountered: