Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages build limits #34003

Closed
1 task done
janbrasna opened this issue Jul 17, 2024 · 8 comments
Closed
1 task done

Pages build limits #34003

janbrasna opened this issue Jul 17, 2024 · 8 comments
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages SME reviewed An SME has reviewed this issue/PR

Comments

@janbrasna
Copy link
Contributor

janbrasna commented Jul 17, 2024

Code of Conduct

What article on docs.github.com is affected?

https://github.com/github/docs/blob/main/content/pages/getting-started-with-github-pages/about-github-pages.md#usage-limits

What part(s) of the article would you like to see updated?

{% data variables.product.prodname_pages %} sites have a soft limit of 10 builds per hour. This limit does not apply if you build and publish your site with a custom {% data variables.product.prodname_actions %} workflow.

Additional information

Now the builds are only run using actions infrastructure. Does the limit of numbers of runs still apply? Or is it limited by available runner minutes only?

(Or that limit of runs is solely for the implicit pages builds in actions without an explicit workflow file?)

@janbrasna janbrasna added the content This issue or pull request belongs to the Docs Content team label Jul 17, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 17, 2024
@janbrasna

This comment was marked as resolved.

@janbrasna janbrasna closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@janbrasna

This comment was marked as resolved.

@janbrasna janbrasna reopened this Jul 17, 2024
@janbrasna
Copy link
Contributor Author

Actually no, I would still love some clarification for that.

As the build limits were for non-action builds. Builds with actions, no matter if implicit or custom workflow all incur minutes against the allotment:

Your GitHub Pages site is built and deployed with a GitHub Actions workflow. For more information, see "Viewing workflow run history".
Note: GitHub Actions is free for public repositories. Usage charges apply for private and internal repositories that go beyond the monthly allotment of free minutes. For more information, see "Usage limits, billing, and administration".

So with the legacy pagesworker gone and all builds now happening via actions infrastructure, any build limits are now imposed via runner minutes. Does the quoted "10 builds per hour" limit apply in addition to any actions allotment?

@nguyenalex836 nguyenalex836 added waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Jul 18, 2024
@nguyenalex836
Copy link
Contributor

@janbrasna Thanks so much for opening an issue! I'll get this triaged for review ✨

@felicitymay felicitymay added needs SME This proposal needs review from a subject matter expert and removed waiting for review Issue/PR is waiting for a writer's review labels Jul 19, 2024
Copy link
Contributor

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@janbrasna Hello! Thank you for your patience while our SME team reviewed ✨

Our SMEs would like to keep the information documentation you highlighted regarding the soft limits as is. They are defined to set the baseline for what we consider "abuse" and give us permission to take down a site causing troubles. For this reason, I'll be closing this issue 💛

@nguyenalex836 nguyenalex836 added SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert labels Jul 29, 2024
@janbrasna
Copy link
Contributor Author

Sure, just wanted to ping if they are still current with the recent worker sunset. Thanks for taking the time to confirm it is indeed still valid and sorry for raising this unnecessarily!

@nguyenalex836
Copy link
Contributor

@janbrasna No need to apologize! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

No branches or pull requests

3 participants