Pages publishing source visibility

[janbrasna]

Code of Conduct

• I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#about-publishing-sources

(these are all reusables, so it should be considered in all its occurrences…)

What part(s) of the article would you like to see updated?

Warning

Warning: GitHub Pages sites are publicly available on the internet, even if the repository for the site is private. If you have sensitive data in your site's repository, you may want to remove the data before publishing. For more information, see "About repositories."

This is actually slightly outdated, as free private repos can't publish at all, and paid private repos have the choice as noted elsewhere:

Note

Note: Organization owners can restrict the publication of GitHub Pages sites from repositories owned by the organization. For more information, see "Managing the publication of GitHub Pages sites for your organization."

Additional information

More info about the visibility/settings: https://docs.github.com/en/organizations/managing-organization-settings/managing-the-publication-of-github-pages-sites-for-your-organization

[nguyenalex836]

@janbrasna Thanks so much for opening an issue! I'll get this triaged for review ✨

[github-actions]

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

[nguyenalex836]

@janbrasna Thank you for your patience while our SME team reviewed! You are correct - that warning is outdated. You, or anyone else, is welcome to submit a PR to remove that warning 💛

[janbrasna]

Just to be sure the options are clear, does this breakdown sound correct?

• Free can publish only public repos to public pages.
• Pro can publish both public and private repos only as public pages?
• Team can publish both public and private repos only as public pages?
• Enterprise Cloud has (as the only plan?) the option to publish pages with restricted access, so that private repos can be published privately, only for collaborator access.
• Enterprise Server … no idea here TBH.

So basically, for most of the plans, the warning is rather reasonable, as even private repos would only publish the sites privately. It just sounds it always deploys public sites, while under some GHEC settings the published sites can be private…

[janbrasna]

In which case the current reusables are correct, the Managed Users are covered in https://docs.github.com/en/enterprise-cloud@latest/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#about-publishing-sources GHEC version of this.

So in reality the FPT warning just somewhat reads as the private-to-public publishing is a feature of FPT, while for Free it has to be public repo. That was maybe the only bit that puzzled me, otherwise all is stated correctly.

So my only nitpick would be adding a note along the lines of:

"Warning: GitHub Pages sites are publicly available on the internet, even if the repository for the site is private (if your plan or organization allows it)."

(copyedit at will…)

[nguyenalex836]

@janbrasna You are correct regarding the breakdown, and that note you added looks perfect 💛 @gagan-bhullar-tech has submitted a PR to address to update the warning, which I will be merging shortly ✨ thank you!