-
Notifications
You must be signed in to change notification settings - Fork 59.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot commit config include: "scope"
output explainer
#33996
Comments
@janbrasna Thanks so much for opening an issue! I'll get this triaged for review ✨ |
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@janbrasna Thank you for your patience while our SME team reviewed!
The team agreed with you here, and would welcome an update to doc stating the only two values possible are those listed in the code you referenced 💛
The team agrees with you here as well, stating the confusion here is that We would welcome an update removing the mention of pip and instead reference another ecosystem that always has dev dependency support (npm) 💛 I've added the |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message
What part(s) of the article would you like to see updated?
There's nowhere a description what this "list of the dependencies updated" is, see #18302 (comment) — only with trial & error or checking the source at https://github.com/dependabot/dependabot-core/blob/3147bb1cd5ea7b5dd3835f0758e42e229ecf8245/common/lib/dependabot/pull_request_creator/pr_name_prefixer.rb#L164-L166:
it's obvious it's only one of these two hard-coded strings (probably chosen from some angular1/2 habits of conventional commits where maybe these exact "token" values have a meaning?), but it's not explained in the docs these would be the only strings added.
Additional information
My additional issue would be that pip is being mentioned as supporting scopes, so somehow Dependabot should be able to select prod vs. dev scopes, but I wasn't able to find out how (as the requirements txt/in files can be named pretty arbitrarily…)
The text was updated successfully, but these errors were encountered: