-
Notifications
You must be signed in to change notification settings - Fork 59.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package authentication documentation has confusing PAT wording #33926
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@syntastical Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for raising this PR. I agree that the text of the note is misleading and have proposed an alternative solution. See: While we discuss the best solution to the problem you identified, I'm going to label this PR as on hold. |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
Reopening per comment here! |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
Why:
Closes: #33925
What's being changed (if available, include any code snippets, screenshots, or gifs):
Both of the following links make reference to only being able to authenticate to GitHub packages using a PAT but that's misleading, and even contradicted on the same page by references to using
GITHUB_SECRET
in GitHub actions.https://docs.github.com/en/packages/learn-github-packages/publishing-a-package
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.