Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: sidebar with brand color #265

Closed
kamaroolkarim opened this issue Oct 8, 2020 · 2 comments
Closed

ui: sidebar with brand color #265

kamaroolkarim opened this issue Oct 8, 2020 · 2 comments
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team

Comments

@kamaroolkarim
Copy link

kamaroolkarim commented Oct 8, 2020

What is the current behavior?

May I know the reason you guys are using blue color on sidebar? The background color is great but I think it has breached your design system which it supposedly to come in black.

Screen Shot 2020-10-08 at 20 36 47

What changes are you suggesting?

As a Product Designer myself, I think it's better to follow the GitHub design system for the documentation as well.

Screen Shot 2020-10-08 at 20 24 57

Screen Shot 2020-10-08 at 20 50 28

Additional information

@kamaroolkarim kamaroolkarim added the engineering Will involve Docs Engineering label Oct 8, 2020
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 8, 2020
@janiceilene
Copy link
Contributor

Thanks for the feedback @kamaroolkarim!

Both the black you’ve shown and the blue that we’re currently using are “brand” colors. For public information about our style guidelines, you can consult https://primer.style. The Docs site was designed by our in-house creative team and conforms to both our branding and style guidelines as well as industry best practices for web accessibility. Because of this, we’re not looking to make design changes especially with regard to the use of color in the documentation.

Thanks for your passion and interest in our new open source documentation!

@kamaroolkarim
Copy link
Author

alright @janiceilene . thank you for your clarification 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

2 participants