Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC w/ AWS example doesn't appear to be valid JSON #11534

Closed
1 task done
Hollywood opened this issue Oct 29, 2021 · 2 comments · Fixed by #11570 or #11621
Closed
1 task done

OIDC w/ AWS example doesn't appear to be valid JSON #11534

Hollywood opened this issue Oct 29, 2021 · 2 comments · Fixed by #11570 or #11621
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@Hollywood
Copy link

Code of Conduct

What article on docs.github.com is affected?

Configuring OpenID Connect in Amazon Web Services

What part(s) of the article would you like to see updated?

The last line in the code block on lines 44 - 47 does not look like valid json:

"Condition": {
  "StringEquals": {
    "token.actions.githubusercontent.com:aud": "https://github.com/octo-org",
    "token.actions.githubusercontent.com:sub": "token.actions.githubusercontent.com:sub": "repo:octo-org/octo-repo:ref:refs/heads/octo-branch"

Was it meant to be?

"Condition": {
  "StringEquals": {
    "token.actions.githubusercontent.com:aud": "https://github.com/octo-org",
    "token.actions.githubusercontent.com:sub": "repo:octo-org/octo-repo:ref:refs/heads/octo-branch"

Additional information

No response

@Hollywood Hollywood added the content This issue or pull request belongs to the Docs Content team label Oct 29, 2021
@welcome
Copy link

welcome bot commented Oct 29, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 29, 2021
@anchorchau
Copy link

anchorchau commented Oct 31, 2021

As far as I tested, the above condition for aud will cause failure if we are using official AWS action aws-actions/configure-aws-credentials as documented. My suggested changes as below:

"Condition": {
  "StringEquals": {
    "token.actions.githubusercontent.com:sub": "repo:octo-org/octo-repo:ref:refs/heads/octo-branch"
  }
}

OR

"Condition": {
  "StringLike": {
    "token.actions.githubusercontent.com:sub": "repo:octo-org/octo-repo:*"
  }
}

@ramyaparimi ramyaparimi removed the triage Do not begin working on this issue until triaged by the team label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
4 participants
@Hollywood @ramyaparimi @anchorchau and others