Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a circular dependency between Schema::ObjectType and Schema::PossibleTypes #22

Closed
wuarmin opened this issue Apr 4, 2024 · 0 comments · Fixed by #23
Closed

Comments

@wuarmin
Copy link
Contributor

wuarmin commented Apr 4, 2024

Hey @rmosolgo 👋 ,

GraphQL::Client::Schema::ObjectType requires "graphql/client/schema/possible_types"

require "graphql/client/schema/possible_types"

and GraphQL::Client::Schema::PossibleTypes requires "graphql/client/schema/object_type"

require "graphql/client/schema/object_type"

I think we need to fix this. Otherwise warnings like this will appear

/usr/local/bundle/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34: warning: /usr/local/bundle/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34: warning: loading in progress, circular require considered harmful - /usr/local/bundle/gems/graphql-client-0.21.0/lib/graphql/client/schema/object_type.rb

Thanks
best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant