Verifying Ginkgo with custom value types #73
Labels
is:enhancement
An improvement of an existing feature.
is:proposal
Maybe we should do something this way.
mod:core
This is related to the core module.
reg:testing
This is related to testing.
Currently we are only compiling Ginkgo for default (
float
,double
,std::complex<>
of those) value types when checking the correctness of our implementation. (We're also testing only fordouble
, see #32 for discussions on that).This means that the interface that
ValueType
needs to have may change after a PR without anyone noticing (e.g. someone used a part of the interface of default types, which user-defined types may not have to implement).I propose we create a dummy
ValueType
implementation (we would create a concept instead if TS concepts were a part of C++11), that could just be adouble
wrapped in a class, and have the interface that Ginkgo'sValueType
has to satisfy defined. This gives us two benefits:ValueType
's interfaceThe text was updated successfully, but these errors were encountered: