Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More warnings with CUDA 11.8 and GCC 11.3.0 #1185

Closed
lahwaacz opened this issue Nov 6, 2022 · 1 comment · Fixed by #1189
Closed

More warnings with CUDA 11.8 and GCC 11.3.0 #1185

lahwaacz opened this issue Nov 6, 2022 · 1 comment · Fixed by #1189

Comments

@lahwaacz
Copy link
Contributor

lahwaacz commented Nov 6, 2022

I'm getting a couple of warnings on the current develop branch:

/build/ginkgo-hpc-git/src/ginkgo/cuda/base/pointer_mode_guard.hpp: In destructor ‘gko::kernels::cuda::cublas::pointer_mode_guard::~pointer_mode_guard()’:
/build/ginkgo-hpc-git/src/ginkgo/cuda/base/pointer_mode_guard.hpp:82:10: warning: ‘bool std::uncaught_exception()’ is deprecated: use 'std::uncaught_exceptions()' instead [-Wdeprecated-declarations]
   82 |         if (std::uncaught_exception()) {
      |          ^~~~~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/include/c++/exception:109:1: note: declared here
  109 |   bool uncaught_exception() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__pure__));
      | ^ ~~~~~~~~~~~~~~~~

(the same appears on a few more places in pointer_mode_guard.hpp)

/build/ginkgo-hpc-git/src/ginkgo/cuda/test/base/index_set.cu(84): warning #177-D: function "<unnamed>::index_set::assert_equal_arrays" was declared but never referenced

From doxygen 1.9.5:

warning: Tag 'CLASS_DIAGRAMS' at line 85 of file '/build/ginkgo-hpc-git/src/build/doc/Doxyfile-usr' has become obsolete.
         To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u"

At runtime, some tests failed:

100/300 Test  #91: omp/test/reorder/rcm_kernels .............................Subprocess aborted***Exception:   0.18 sec
Running main() from /build/gtest/src/googletest-release-1.12.1/googletest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Rcm
[ RUN      ] Rcm.OmpPermutationIsRcmOrdered
/usr/include/c++/12.2.0/bits/stl_vector.h:1123: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = int; _Alloc = gko::ExecutorAllocator<int>; reference = int&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.

223/300 Test #226: test/factorization/par_ilu_kernels_omp ...................Subprocess aborted***Exception:   0.26 sec
Running main() from /build/gtest/src/googletest-release-1.12.1/googletest/src/gtest_main.cc
[==========] Running 56 tests from 8 test suites.
[----------] Global test environment set-up.
[----------] 7 tests from ParIlu/<float, int>, where TypeParam = std::tuple<float, int>
[ RUN      ] ParIlu/<float, int>.KernelAddDiagonalElementsSortedEquivalentToRef
[       OK ] ParIlu/<float, int>.KernelAddDiagonalElementsSortedEquivalentToRef (85 ms)
[ RUN      ] ParIlu/<float, int>.KernelAddDiagonalElementsUnsortedEquivalentToRef
/usr/include/c++/12.2.0/bits/uniform_int_dist.h:97: std::uniform_int_distribution<_IntType>::param_type::param_type(_IntType, _IntType) [with _IntType = int]: Assertion '_M_a <= _M_b' failed.

        Start 227: test/factorization/par_ilu_kernels_cuda
224/300 Test #227: test/factorization/par_ilu_kernels_cuda ..................Subprocess aborted***Exception:   2.55 sec
Running main() from /build/gtest/src/googletest-release-1.12.1/googletest/src/gtest_main.cc
[==========] Running 56 tests from 8 test suites.
[----------] Global test environment set-up.
[----------] 7 tests from ParIlu/<float, int>, where TypeParam = std::tuple<float, int>
[ RUN      ] ParIlu/<float, int>.KernelAddDiagonalElementsSortedEquivalentToRef
[       OK ] ParIlu/<float, int>.KernelAddDiagonalElementsSortedEquivalentToRef (2205 ms)
[ RUN      ] ParIlu/<float, int>.KernelAddDiagonalElementsUnsortedEquivalentToRef
/usr/include/c++/12.2.0/bits/uniform_int_dist.h:97: std::uniform_int_distribution<_IntType>::param_type::param_type(_IntType, _IntType) [with _IntType = int]: Assertion '_M_a <= _M_b' failed.

245/300 Test #248: test/matrix/matrix_omp ...................................Subprocess aborted***Exception:   0.16 sec
Running main() from /build/gtest/src/googletest-release-1.12.1/googletest/src/gtest_main.cc
[==========] Running 323 tests from 17 test suites.
[----------] Global test environment set-up.
[----------] 19 tests from Matrix/DenseWithDefaultStride, where TypeParam = DenseWithDefaultStride
[ RUN      ] Matrix/DenseWithDefaultStride.SpMVIsEquivalentToRef
/usr/include/c++/12.2.0/bits/uniform_int_dist.h:97: std::uniform_int_distribution<_IntType>::param_type::param_type(_IntType, _IntType) [with _IntType = long int]: Assertion '_M_a <= _M_b' failed.

        Start 249: test/matrix/matrix_cuda
246/300 Test #249: test/matrix/matrix_cuda ..................................Subprocess aborted***Exception:   3.08 sec
Running main() from /build/gtest/src/googletest-release-1.12.1/googletest/src/gtest_main.cc
[==========] Running 399 tests from 21 test suites.
[----------] Global test environment set-up.
[----------] 19 tests from Matrix/DenseWithDefaultStride, where TypeParam = DenseWithDefaultStride
[ RUN      ] Matrix/DenseWithDefaultStride.SpMVIsEquivalentToRef
/usr/include/c++/12.2.0/bits/uniform_int_dist.h:97: std::uniform_int_distribution<_IntType>::param_type::param_type(_IntType, _IntType) [with _IntType = long int]: Assertion '_M_a <= _M_b' failed.
@upsj
Copy link
Member

upsj commented Nov 7, 2022

Thanks for the report! We can't do anything about the unhandled_exception warning without requiring C++17 support or some hacky workarounds that I'd like to avoid. The assertion failures are tracked with #1143, the rest should be fixed by #1189

@upsj upsj closed this as completed in #1189 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants