Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GMRES lucky breakdown #1025

Open
upsj opened this issue Apr 20, 2022 · 1 comment
Open

Fix GMRES lucky breakdown #1025

upsj opened this issue Apr 20, 2022 · 1 comment
Assignees
@upsj
Labels
is:bug Something looks wrong. is:enhancement An improvement of an existing feature. is:todo This issue describes a concrete task to be done type:solver This is related to the solvers type:stopping-criteria This is related to the stopping criteria

Comments

@upsj
Copy link
Member

upsj commented Apr 20, 2022 •
edited
Loading

Currently we don't correctly deal with the case that the initial guess already solves Ax=b, which leads to NaNs in (CB-)GMRES in #973. This should be fixed before the next release, probably by stopping early even if the stopping criterion has not yet fired.
@upsj upsj added the is:enhancement An improvement of an existing feature. label Apr 20, 2022
@upsj upsj added this to the Ginkgo 1.5.0 milestone Apr 20, 2022
@upsj upsj self-assigned this Apr 20, 2022
@tcojean tcojean added the is:bug Something looks wrong. label Apr 20, 2022
@Slaedr Slaedr added type:solver This is related to the solvers type:stopping-criteria This is related to the stopping criteria labels Apr 26, 2022
@upsj upsj removed this from the Ginkgo 1.5.0 milestone Nov 2, 2022
@upsj upsj added the is:todo This issue describes a concrete task to be done label Nov 23, 2022
@MarcelKoch
Copy link
Member

We already had tests which cover this behavior, but they are currently disabled. I will create a fix for that.

@MarcelKoch MarcelKoch mentioned this issue Apr 21, 2023
Merged
@MarcelKoch MarcelKoch linked a pull request Apr 21, 2023 that will close this issue
Some bug fixes for the next release #1327
Merged
@MarcelKoch MarcelKoch removed a link to a pull request May 10, 2023
Some bug fixes for the next release #1327
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upsj upsj

Labels
is:bug Something looks wrong. is:enhancement An improvement of an existing feature. is:todo This issue describes a concrete task to be done type:solver This is related to the solvers type:stopping-criteria This is related to the stopping criteria
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@upsj @MarcelKoch @Slaedr @tcojean