Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change showAccessibleTab() to allow a tab id as param as well #15

Closed
ginader opened this issue Apr 11, 2011 · 2 comments
Closed

change showAccessibleTab() to allow a tab id as param as well #15

ginader opened this issue Apr 11, 2011 · 2 comments

Comments

@ginader
Copy link
Owner

ginader commented Apr 11, 2011

According to Marcus' comment here:
http://blog.ginader.de/isok/comment/955/257-jQuery-Accessible-Tabs-How-to-make-tabs-REALLY-accessible.html#c955

Following on from autoAnchor, it would be handy if it were possible to pass the ID value of a tab to .showAccessibleTab() - e.g. tabs.showAccessibleTab("MyTabHeadingID") - instead of only accepting the 0-based index position.

I think either having an integer or a valid jQuery Selector would be the best approach.

@ginader
Copy link
Owner Author

ginader commented Apr 11, 2011

fixed in version 1.9
new method showAccessibleTabSelector({valid jQuery selector of the tab to show}) that allows the opening of tabs by jQuery Selector instead of the index in showAccessibleTab()

@ginader ginader closed this as completed Apr 11, 2011
@MarcusJT
Copy link

Thanks for your speedy implementation BUT you don't actually need a new function, nor is it desirable - a jQuery selector can (and often does) return multiple elements, but only one tab can be active at a time, so showAccessibleTabSelector() doesn't make much sense in that context IMHO.

And fortunately, element IDs can't start with a number anyway (part of the HTML spec) so if the parameter passed to showAccessibleTab() is text you should handle it as an ID, and if it's a number you should handle it as an tab array index!

@ginader ginader reopened this Apr 18, 2011
@ginader ginader closed this as completed Mar 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants